Change in vdsm[master]: teach addNetwork to add a netwrok to an existing bridge

ibarkan at redhat.com ibarkan at redhat.com
Sun Dec 14 13:41:37 UTC 2014


Ido Barkan has posted comments on this change.

Change subject: teach addNetwork to add a netwrok to an existing bridge
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.ovirt.org/#/c/35922/8/vdsm/network/api.py
File vdsm/network/api.py:

Line 309:         _netinfo=_netinfo, configurator=configurator, opts=options)
Line 310: 
Line 311:     if bridged and network in _netinfo.bridges:
Line 312:         net_ent_to_configure = net_ent.port
Line 313:         logging.info("Bridge %s already exists." % (network,))
fix logging method
Line 314:     else:
Line 315:         net_ent_to_configure = net_ent
Line 316: 
Line 317:     if net_ent_to_configure is not None:


Line 314:     else:
Line 315:         net_ent_to_configure = net_ent
Line 316: 
Line 317:     if net_ent_to_configure is not None:
Line 318:         logging.info("Configuring device %s" % (net_ent_to_configure,))
fix logging method
Line 319:         net_ent_to_configure.configure(**options)
Line 320:     configurator.configureLibvirtNetwork(network, net_ent)
Line 321:     if hostQos is not None:
Line 322:         configurator.configureQoS(hostQos, net_ent)


-- 
To view, visit http://gerrit.ovirt.org/35922
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0df074c6c9d5f846748c2cff2cc14ba24305123b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list