Change in vdsm[master]: teach delNetworks to remove a network entity under a bridge

ibarkan at redhat.com ibarkan at redhat.com
Sun Dec 14 06:39:14 UTC 2014


Ido Barkan has posted comments on this change.

Change subject: teach delNetworks to remove a network entity under a bridge
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.ovirt.org/#/c/35921/7/vdsm/network/api.py
File vdsm/network/api.py:

Line 466:     # network is still up, the network entity (In some flows) thinks that
Line 467:     # it still has users and thus does not allow its removal
Line 468:     configurator.removeLibvirtNetwork(network)
Line 469:     if net_ent_to_remove is not None:
Line 470:         logging.info('Removing network entity %s' % (net_ent_to_remove,))
> Please consider switching to str.format or making 'net_ent_to_remove' a par
Done
Line 471:         net_ent_to_remove.remove()
Line 472:     # We must remove the QoS last so that no devices nor networks mark the
Line 473:     # QoS as used
Line 474:     backing_device = hierarchy_backing_device(net_ent)


-- 
To view, visit http://gerrit.ovirt.org/35921
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6bb891f23ef4550f90c6c7b057aef6302cf435c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list