Change in vdsm[master]: teach delNetworks to remove a network entity under a bridge
osvoboda at redhat.com
osvoboda at redhat.com
Fri Dec 12 16:43:11 UTC 2014
Ondřej Svoboda has posted comments on this change.
Change subject: teach delNetworks to remove a network entity under a bridge
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
Remarks to formatting in logging functions (it follows the "old", not recommended style).
I will attempt to do a proper review later :-)
http://gerrit.ovirt.org/#/c/35921/7/vdsm/network/api.py
File vdsm/network/api.py:
Line 466: # network is still up, the network entity (In some flows) thinks that
Line 467: # it still has users and thus does not allow its removal
Line 468: configurator.removeLibvirtNetwork(network)
Line 469: if net_ent_to_remove is not None:
Line 470: logging.info('Removing network entity %s' % (net_ent_to_remove,))
Please consider switching to str.format or making 'net_ent_to_remove' a parameter to logging.info and similarly in logging function that you introduce or modify :-)
logging.info('Removing network entity {0}'.format(net_ent_to_remove))
logging.info('Removing network entity %s', net_ent_to_remove)
Line 471: net_ent_to_remove.remove()
Line 472: # We must remove the QoS last so that no devices nor networks mark the
Line 473: # QoS as used
Line 474: backing_device = hierarchy_backing_device(net_ent)
--
To view, visit http://gerrit.ovirt.org/35921
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6bb891f23ef4550f90c6c7b057aef6302cf435c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list