Change in vdsm[master]: ipwrapperTests: prevent infinite stuck

phoracek at redhat.com phoracek at redhat.com
Wed Dec 10 10:15:22 UTC 2014


Petr Horáček has posted comments on this change.

Change subject: ipwrapperTests: prevent infinite stuck
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/35901/3/tests/ipwrapperTests.py
File tests/ipwrapperTests.py:

Line 160:         mon.start()
Line 161: 
Line 162:         def _timeout():
Line 163:             mon.stop()
Line 164:             raise MonitorError("Test timeout")
> Who receives this information? is it thrown to stderr somewhere?
It's printed out via stderr, it looks like this: http://fpaste.org/158279/20620214/

Logging is fine, but i would be happier if it will be visible directly in tests output, but not this ugly way. I'm gonna try to find a non-hacky way to throw that Exception from the main thread.
Line 165: 
Line 166:         timer = Timer(3, _timeout)
Line 167:         timer.start()
Line 168:         try:


-- 
To view, visit http://gerrit.ovirt.org/35901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie71eb5b33cabf5402f00815aa603bbc384159d56
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list