Change in vdsm[master]: ipwrapperTests: prevent infinite stuck

danken at redhat.com danken at redhat.com
Tue Dec 9 17:37:05 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: ipwrapperTests: prevent infinite stuck
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/35901/3/tests/ipwrapperTests.py
File tests/ipwrapperTests.py:

Line 159
Line 160
Line 161
Line 162
Line 163
I liked this whitespace. never mind.


Line 160:         mon.start()
Line 161: 
Line 162:         def _timeout():
Line 163:             mon.stop()
Line 164:             raise MonitorError("Test timeout")
> I would like to raise it and give an information about the problem, but unf
Who receives this information? is it thrown to stderr somewhere?

A safer approach would be to add

  logging.error('waiting too long for a monitor event')
Line 165: 
Line 166:         timer = Timer(3, _timeout)
Line 167:         timer.start()
Line 168:         try:


-- 
To view, visit http://gerrit.ovirt.org/35901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie71eb5b33cabf5402f00815aa603bbc384159d56
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list