Change in vdsm[master]: jsonrpc: Host_getVMList

fromani at redhat.com fromani at redhat.com
Wed Dec 10 08:43:38 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: jsonrpc: Host_getVMList
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

improvement, but still not there. Need work on future patches.

http://gerrit.ovirt.org/#/c/35524/3/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 3587: # Since: 4.10.0
Line 3588: ##
Line 3589: {'command': {'class': 'Host', 'name': 'getVMList'},
Line 3590:  'data': {'*fullStatus': 'bool','*vmList': ['UUID']},
Line 3591:  'returns': ['UUID']}
This patch is an improvement but the schema is still not correct. Needs more work on different patches.

Most likely the root cause is this API being confusing and doing two quite different things.

if fullStatus == False, returns just a list of {'vmId':UUID, 'status': VM_STATUS } - being VM_STATUS an enum already defined in the schema.

Else, it returns a list of VmDefinitions.

Cleanup proposal:

http://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:vm_status_report,n,z
Line 3592: 
Line 3593: ##
Line 3594: # @GuestDiskMappingInfo:
Line 3595: #


-- 
To view, visit http://gerrit.ovirt.org/35524
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I272a349a0a5237b94ea2ebdce3f4588270b42548
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list