Change in vdsm[master]: jsonrpc: VM_snapshot

fromani at redhat.com fromani at redhat.com
Wed Dec 10 08:35:45 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: jsonrpc: VM_snapshot
......................................................................


Patch Set 3: Code-Review-1

It should be fixed the other way around. Despite its ugliness, the name in API.py is the more correct because just 'snapMemory' could be misleading.

So, please keep the name in API.py and change the schema.

-- 
To view, visit http://gerrit.ovirt.org/35555
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8af5bf7d0b15e98ad1352bffe3ee41ef2bccbe2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list