Change in vdsm[master]: vm, guestagent: hash to include also the disk mapping

fromani at redhat.com fromani at redhat.com
Thu Aug 21 10:41:46 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm, guestagent: hash to include also the disk mapping
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.ovirt.org/#/c/31701/3/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py:

Line 304:                 disks.append(disk)
Line 305:             self.guestInfo['disksUsage'] = disks
Line 306:             self.guestDiskMapping = args.get('mapping', {})
Line 307:             self.diskMappingHash = hash(json.dumps(self.guestDiskMapping,
Line 308:                                                     sort_keys=True))
> same as the other comment in this file.
do we need to use json here or a simpler str() would be sufficient?

BTW I think str() is good enough;  if you disagree please explain why.
Line 309:         elif message == 'number-of-cpus':
Line 310:             self.guestInfo['guestCPUCount'] = int(args['count'])
Line 311:         else:
Line 312:             self.log.error('Unknown message type %s', message)


http://gerrit.ovirt.org/#/c/31701/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1543:         self._qemuguestSocketFile = self._makeChannelPath(_QEMU_GA_DEVICE_NAME)
Line 1544:         self.guestAgent = guestagent.GuestAgent(
Line 1545:             self._guestSocketFile, self.cif.channelListener, self.log)
Line 1546:         self._lastXMLDesc = '<domain><uuid>%s</uuid></domain>' % self.id
Line 1547:         self._devXmlHash = 0
> This change is not needed.
+1
Line 1548:         self._released = False
Line 1549:         self._releaseLock = threading.Lock()
Line 1550:         self.saveState()
Line 1551:         self._watchdogEvent = {}


Line 4514:     def _getUnderlyingVmInfo(self):
Line 4515:         self._lastXMLDesc = self._dom.XMLDesc(0)
Line 4516:         devxml = _domParseStr(self._lastXMLDesc).childNodes[0]. \
Line 4517:             getElementsByTagName('devices')[0]
Line 4518:         self._devXmlHash = hash(devxml.toxml())
> I don't think that it's matter of "cares", imo there's no reason to leave t
+1 with Nir again. If you believe the change at this line it is an improvement, or if in general you want to improve how hashes are handled (which *is* a good thing indeed), please post a separate patch
Line 4519: 
Line 4520:         return self._lastXMLDesc
Line 4521: 
Line 4522:     def _ejectFloppy(self):


-- 
To view, visit http://gerrit.ovirt.org/31701
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I148196ccf353613f9cffed7753e7100bd1dd30de
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list