Change in vdsm[master]: vm, guestagent: hash to include also the disk mapping
laravot at redhat.com
laravot at redhat.com
Thu Aug 21 06:18:05 UTC 2014
Liron Aravot has posted comments on this change.
Change subject: vm, guestagent: hash to include also the disk mapping
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31701/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4514: def _getUnderlyingVmInfo(self):
Line 4515: self._lastXMLDesc = self._dom.XMLDesc(0)
Line 4516: devxml = _domParseStr(self._lastXMLDesc).childNodes[0]. \
Line 4517: getElementsByTagName('devices')[0]
Line 4518: self._devXmlHash = hash(devxml.toxml())
> Nobody care about these conversions.
I don't think that it's matter of "cares", imo there's no reason to leave them and to add the new hash as a string as well, the reason for having it stored as string is gone in this change.
Line 4519:
Line 4520: return self._lastXMLDesc
Line 4521:
Line 4522: def _ejectFloppy(self):
--
To view, visit http://gerrit.ovirt.org/31701
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I148196ccf353613f9cffed7753e7100bd1dd30de
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list