Change in vdsm[master]: vdsm-tool: roll out self signed certificates in vdsm-tool.
mtayer at redhat.com
mtayer at redhat.com
Mon Aug 18 13:25:36 UTC 2014
mooli tayer has posted comments on this change.
Change subject: vdsm-tool: roll out self signed certificates in vdsm-tool.
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/31562/2/lib/vdsm/tool/configurators/certificates.py
File lib/vdsm/tool/configurators/certificates.py:
Line 45: def getName(self):
Line 46: return 'certificates'
Line 47:
Line 48: def validate(self):
Line 49: return self._certsExists()
opps, this is a bug.
Since vdsm supports ssl false this should be
return ssl = Falsd or self._certsExist()
Line 50:
Line 51: def _exec_vdsm_gencerts(self):
Line 52: rc, out, err = execCmd(
Line 53: (
Line 73:
Line 74: def isconfigured(self):
Line 75: return CONFIGURED if self._certsExists() else NOT_CONFIGURED
Line 76:
Line 77: def _certsExists(self):
_certsExist
--
To view, visit http://gerrit.ovirt.org/31562
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53d927e49920e8c45d02718f2b6ef5dff63eead0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list