Change in vdsm[master]: vdsm-tool: roll out self signed certificates in vdsm-tool.
mtayer at redhat.com
mtayer at redhat.com
Mon Aug 18 12:00:43 UTC 2014
mooli tayer has posted comments on this change.
Change subject: vdsm-tool: roll out self signed certificates in vdsm-tool.
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/31562/1/lib/vdsm/tool/configurators/certificates.py
File lib/vdsm/tool/configurators/certificates.py:
Line 71:
Line 72: def configure(self):
Line 73: self._exec_vdsm_gencerts()
Line 74: if isOvirtNode():
Line 75: validate_ovirt_certs.validate_ovirt_certs()
> I believe that if this is not done automatically when vdsm starts, it will
It was created originally here:
http://gerrit.ovirt.org/#/c/4345/
@Douglas is this still relevant?
Line 76:
Line 77: def isconfigured(self):
Line 78: if self._certsExists():
Line 79: ret = CONFIGURED
Line 88: return all(os.path.isfile(f) for f in [
Line 89: CA_FILE,
Line 90: CERT_FILE,
Line 91: KEY_FILE
Line 92: ])
> I am saying that if it exist, you should not override anything even if othe
So I should not fail..
OK so I will just check for the CERT_FILE.
--
To view, visit http://gerrit.ovirt.org/31562
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53d927e49920e8c45d02718f2b6ef5dff63eead0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list