Change in vdsm[master]: vdsm-infra: zombie-reaper refactor

ybronhei at redhat.com ybronhei at redhat.com
Sun Aug 17 15:59:28 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm-infra: zombie-reaper refactor
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.ovirt.org/#/c/31301/1//COMMIT_MSG
Commit Message:

Line 10: are organized.
Line 11: 
Line 12: It uses zombie-reaper as a sample use case.
Line 13: Also removes the deprecated documentation in /doc/ and adds
Line 14: documentation for zombie-reaper.
maybe do the /doc/ changes separately ?
Line 15: 
Line 16: Change-Id: I86a7d8d2f512395c2f50e21430b9e939f553e91b


http://gerrit.ovirt.org/#/c/31301/1/configure.ac
File configure.ac:

Line 132: AC_SUBST([vdsmtsdir], ['${sysconfdir}/pki/vdsm'])
Line 133: AC_SUBST([vdsmrepo], ['/rhev/data-center'])
Line 134: AC_SUBST([vdsmpylibdir], ['${pyexecdir}/vdsm'])
Line 135: AC_SUBST([vdsminfradir], ['${vdsmpylibdir}/infra'])
Line 136: AC_SUBST([zombiereaperdir], ['${vdsminfradir}/zombiereaper'])
don't you need to define vdsminfradir first?
Line 137: AC_SUBST([vdsmtooldir], ['${vdsmpylibdir}/tool'])
Line 138: AC_SUBST([vdsmtestsdir], ['${datarootdir}/vdsm/tests'])
Line 139: 
Line 140: # VDSM registration default paths


http://gerrit.ovirt.org/#/c/31301/1/lib/vdsm/infra/Makefile.am
File lib/vdsm/infra/Makefile.am:

Line 1: #
Line 2: # Copyright 2013 Hat, Inc.
its 2014. they all keep saying that in the us
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


http://gerrit.ovirt.org/#/c/31301/1/lib/vdsm/infra/zombiereaper/__init__.py
File lib/vdsm/infra/zombiereaper/__init__.py:

Line 1: """
add copyrights
Line 2: ZombieReaper is a module to handle the annoying problem of cleaning up child
Line 3: processes. Specifically, for cases where the result of the child process is not
Line 4: needed.
Line 5: 


http://gerrit.ovirt.org/#/c/31301/1/lib/vdsm/infra/zombiereaper/tests.py
File lib/vdsm/infra/zombiereaper/tests.py:

Line 21: import os
Line 22: 
Line 23: import sys
Line 24: sys.path.append("..")
Line 25: import zombiereaper
why do you need it? can't you do it normally with import ..zombierepear?
Line 26: from cpopen import CPopen
Line 27: 
Line 28: from unittest import TestCase
Line 29: 


http://gerrit.ovirt.org/#/c/31301/1/vdsm.spec.in
File vdsm.spec.in:

Line 303: Summary:        Collects zombie processes automatically
Line 304: BuildArch:      noarch
Line 305: 
Line 306: Requires:       python >= 2.6
Line 307: Obsoletes:	python-zombiereaper
redundant tag
Line 308: 
Line 309: %description infra
Line 310: Collects zombie processes automatically so you don't have to
Line 311: 


-- 
To view, visit http://gerrit.ovirt.org/31301
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86a7d8d2f512395c2f50e21430b9e939f553e91b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list