Change in vdsm[master]: supervdsm: Add zombiereaper to supervdsm
danken at redhat.com
danken at redhat.com
Mon Aug 11 00:05:00 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsm: Add zombiereaper to supervdsm
......................................................................
Patch Set 10: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/28915/10/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line 244: # If it didn't fail because process is already dead
Line 245: if e.errno != errno.ESRCH:
Line 246: raise
Line 247:
Line 248: raise Timeout()
I thought that our problem is actually here - we raise Timeout without calling terminate() (as we cannot wait for the subprocess any longer). The process is then left untracked, ultimately turning into a zombie.
terminate() waits on the child, so zombiereaper is not needed on the positive flow; only "except:" (and only when terminate fails) should be used to autoreap the child.
Line 249:
Line 250: try:
Line 251: res, err = pipe.recv()
Line 252: pipe.send("Bye")
--
To view, visit http://gerrit.ovirt.org/28915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5333caf7a1162c5d783f556bb9204fb74d1ab469
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list