Change in vdsm[master]: vm: Pause vm in case volume allocation is greater than lv size

sgotliv at redhat.com sgotliv at redhat.com
Tue Oct 29 22:18:28 UTC 2013


Sergey Gotliv has posted comments on this change.

Change subject: vm: Pause vm in case volume allocation is greater than lv size
......................................................................


Patch Set 2:

(3 comments)

....................................................
File vdsm/vm.py
Line 509:                 self._vm._dom.blockInfo(vmDrive.path, 0)
Line 510: 
Line 511:             if physical - alloc < 0:
Line 512:                 self._vm.pause(pauseCode='EOTHER')
Line 513:                 self._log.error('vm: %s paused due to the corrupt volume: %s',
Done
Line 514:                                 self._vm.id, vmDrive.path)
Line 515:                 continue
Line 516: 
Line 517:             if physical - alloc >= vmDrive.watermarkLimit:


Line 511:             if physical - alloc < 0:
Line 512:                 self._vm.pause(pauseCode='EOTHER')
Line 513:                 self._log.error('vm: %s paused due to the corrupt volume: %s',
Line 514:                                 self._vm.id, vmDrive.path)
Line 515:                 continue
Done
Line 516: 
Line 517:             if physical - alloc >= vmDrive.watermarkLimit:
Line 518:                 continue
Line 519: 


Line 4211:                     #in the case of a qcow2-like file stored inside a block
Line 4212:                     #device 'physical' will give the block device size, while
Line 4213:                     #'allocation' will give the qcow2 image size
Line 4214:                     #D. Berrange
Line 4215:                     capacity, alloc, physical = self._dom.blockInfo(d.path, 0)
The logic looks pretty similar, but see this comment: 
https://bugzilla.redhat.com/show_bug.cgi?id=998443#c6

It seems like the real issue was observed in the highWrite scope only.
Line 4216:                     if (physical >
Line 4217:                         (alloc + config.getint(
Line 4218:                             'irs', 'volume_utilization_chunk_mb'))):
Line 4219:                         self.log.warn('%s = %s/%s error %s phys: %s alloc: %s '


-- 
To view, visit http://gerrit.ovirt.org/19719
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list