Change in vdsm[master]: vm: Pause vm in case volume allocation is greater than lv size

abaron at redhat.com abaron at redhat.com
Thu Oct 3 09:49:22 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: vm: Pause vm in case volume allocation is greater than lv size
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/vm.py
Line 511:             if physical - alloc < 0:
Line 512:                 self._vm.pause(pauseCode='EOTHER')
Line 513:                 self._log.error('vm: %s paused due to the corrupt volume: %s',
Line 514:                                 self._vm.id, vmDrive.path)
Line 515:                 continue
I wonder if we should not in fact avoid any extend operations on this entire VM in this case since something went awfully wrong here and I don't think we should be doing anything in this state.
If we go down this path that would also mean that extendDriveVolume should be called outside of the for loop only on valid drives and only if we did not hit this case (so collect list of disks to extend and raise here if encounter error or something)
Line 516: 
Line 517:             if physical - alloc >= vmDrive.watermarkLimit:
Line 518:                 continue
Line 519: 


-- 
To view, visit http://gerrit.ovirt.org/19719
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list