Change in vdsm[master]: vdsm: move watchdog default params to WatchdogDevice

abaron at redhat.com abaron at redhat.com
Mon Oct 14 21:51:20 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: vdsm: move watchdog default params to WatchdogDevice
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/vm.py
Line 1631: 
Line 1632: 
Line 1633: class WatchdogDevice(VmDevice):
Line 1634:     def __init__(self, *args, **kwargs):
Line 1635:         super(WatchdogDevice, self).__init__(*args, **kwargs)
It would be a lot clearer if the properties of each device were explicit.
I don't see the point of inheriting from VmDevice as it isn't really giving us anything.
You can instead specify here the two params that a WatchDogDevice should have and set the default values if not passed.
Line 1636: 
Line 1637:         if not hasattr(self, 'specParams'):
Line 1638:             self.specParams = {}
Line 1639: 


-- 
To view, visit http://gerrit.ovirt.org/19331
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic76f040bf78cbec3129569eb30fbf14447f742d6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list