Change in vdsm[master]: vdsm: refactor buildConfDevices and getConfDevices into sing...

abaron at redhat.com abaron at redhat.com
Mon Oct 14 21:49:01 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: vdsm: refactor buildConfDevices and getConfDevices into single function
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/vm.py
Line 1856:                 'index': 0,
Line 1857:                 'truesize': 0})
Line 1858:         return removables
Line 1859: 
Line 1860:     def buildConfDevices(self):
This patch needs to be rebased on top of http://gerrit.ovirt.org/#/c/1932 and that way the balloon part above disappearing would make sense.
Line 1861:         """
Line 1862:         Return the "devices" section of this Vm's conf.
Line 1863:         If missing, create it according to old API.
Line 1864:         """


-- 
To view, visit http://gerrit.ovirt.org/19348
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd3a209967f97a55fe861c4446e8f93e1a1da08e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list