Change in vdsm[master]: Network functional tests assertion improvements

danken at redhat.com danken at redhat.com
Fri Oct 11 21:06:05 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Network functional tests assertion improvements
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

....................................................
Commit Message
Line 6: 
Line 7: Network functional tests assertion improvements
Line 8: 
Line 9: This change allows for more fine grained assertion errors. It allows
Line 10: , among other things, to differentiate if what failed is making a
English style: no leading comma please.
Line 11: net or putting it into the running configuration.
Line 12: 
Line 13: Change-Id: Icca9a552272818039bc677c6adebfed3d5664454


....................................................
File tests/functional/networkTests.py
Line 146: 
Line 147:     def assertNetworkExists(self, networkName, bridged=None):
Line 148:         netinfo = self.vdsm_net.netinfo
Line 149:         config = self.vdsm_net.config
Line 150:         self.assertTrue(networkName in netinfo.networks)
using assertIn() (after pulling it to python 2.6) would provide clearer outputs in case of assertion. Ancient Ruth had it.
Line 151:         if bridged is not None:
Line 152:             self.assertEqual(bridged, netinfo.networks[networkName]['bridged'])
Line 153:         if config is not None:
Line 154:             self.assertTrue(networkName in config.networks)


-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list