Change in vdsm[master]: Network functional tests assertion improvements

asegurap at redhat.com asegurap at redhat.com
Fri Oct 11 20:27:16 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: Network functional tests assertion improvements
......................................................................


Patch Set 1:

(1 comment)

....................................................
File tests/functional/networkTests.py
Line 234:                 {},
Line 235:                 {BONDING_NAME: {'remove': True}}, {'connectivityCheck': False})
Line 236:             self.assertEqual(status, SUCCESS, msg)
Line 237: 
Line 238:     def assertNetworkExists(self, networkName, bridged=None):
In fact my original code was the new asserts in networkTests. But since we originally didn't want this module to access self.vdsm_net.netinfo nor config I moved it there. 

This method is not used and it is a glitch of my git cherry-picking.
Line 239:         self.assert_(networkName in self.vdsm_net.netinfo.networks)
Line 240:         if bridged:
Line 241:             self.assertEqual(
Line 242:                 bridged,


-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list