Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.

ybronhei at redhat.com ybronhei at redhat.com
Thu Oct 3 06:32:25 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: supervdsm: Enable multiprocessing module logging.
......................................................................


Patch Set 2:

OK, after running it I can also confirm the client side. Although I see that each call to proxy we get the following print:

 (debug) thread 'Thread-16' does not own a connection
 (debug) making connection to manager

That I actually not sure I understand. But the other prints are valuable and very good to have. Especially in server side, for that my +1 also on verified is guaranteed .

Please first change to True instead of 1, and import only what needed.

But just fyi, in vdsm version you use, you don't include the patch http://gerrit.ovirt.org/17199 that fixes the usage with the log. With that you have almost everything you need, except the broken connection in supervdsm.log. The broken connection you can see clearly in vdsm.log side and in supervdsm.log the non responsiveness .. in your verification please try to patch in 17199 to your environment to see if your improvement still has its value.

Thanks!

-- 
To view, visit http://gerrit.ovirt.org/19741
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Gibson <dgibson at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list