Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.

ybronhei at redhat.com ybronhei at redhat.com
Wed Oct 2 17:17:23 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: supervdsm: Enable multiprocessing module logging.
......................................................................


Patch Set 2:

(4 comments)

I'm still feeling unconformable with this patch, adding log prints from external package that we probably don't care much about. Can you share a print that important to vdsm, that vdsm\supervdsm doesn't report about? I'm worried about too many prints that we don't need and we don't have control on. Don't you agree?

....................................................
File vdsm/supervdsm.py
Line 20: #
Line 21: 
Line 22: import os
Line 23: import multiprocessing
Line 24: from multiprocessing.managers import BaseManager, RemoteError
import specific packages and classes or import all package, its odd to have both
Line 25: import logging
Line 26: import threading
Line 27: from vdsm import constants, utils
Line 28: 


Line 60:     """
Line 61:     A wrapper around all the supervdsm init stuff
Line 62:     """
Line 63:     _log = logging.getLogger("SuperVdsmProxy")
Line 64:     multiprocessing.get_logger().propagate = 1
please assign True instead and verify that it doesn't dirt the log. I'll check it too
Line 65: 
Line 66:     def __init__(self):
Line 67:         self.proxyLock = threading.Lock()
Line 68:         self._manager = None


....................................................
File vdsm/supervdsmServer
Line 42:     log = logging.getLogger("SuperVdsm.Server")
Line 43:     log.warn("Could not init proper logging", exc_info=True)
Line 44: 
Line 45: from storage import fuser
Line 46: from multiprocessing import Pipe, Process
union the imports please
Line 47: from gluster import listPublicFunctions
Line 48: import storage.misc as misc
Line 49: from vdsm import utils
Line 50: from parted_utils import getDevicePartedInfo as _getDevicePartedInfo


Line 356: 
Line 357: 
Line 358: def main(sockfile, pidfile=None):
Line 359:     log = logging.getLogger("SuperVdsm.Server")
Line 360:     multiprocessing.get_logger().propagate = 1
assign True
Line 361: 
Line 362:     def bind(func):
Line 363:         def wrapper(_SuperVdsm, *args, **kwargs):
Line 364:             return func(*args, **kwargs)


-- 
To view, visit http://gerrit.ovirt.org/19741
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Gibson <redhat at gibson.dropbear.id.au>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list