Change in vdsm[master]: vdsm: pre-defined range for spice/vnc ports

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Mon Nov 25 11:22:33 UTC 2013


Michal Skrivanek has posted comments on this change.

Change subject: vdsm: pre-defined range for spice/vnc ports
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 260:     fi
Line 261: 
Line 262:     # Configure remote display port range
Line 263:     set_if_default "${qconf}" remote_display_port_min 5900
Line 264:     set_if_default "${qconf}" remote_display_port_max 6923
I'd mention it in the commit message
Line 265: 
Line 266:     # Configuring sanlock
Line 267:     if [ "${ENABLE_LIBVIRT_SANLOCK}" = "yes" ]; then
Line 268:         set_if_default "${qconf}" lock_manager \"sanlock\"


-- 
To view, visit http://gerrit.ovirt.org/17058
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list