Change in vdsm[master]: vdsm: Reboot capability for VM

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Mon Nov 25 11:17:32 UTC 2013


Michal Skrivanek has posted comments on this change.

Change subject: vdsm: Reboot capability for VM
......................................................................


Patch Set 33:

(1 comment)

....................................................
File vdsm/vm.py
Line 1780:         while not check():
Line 1781:             if time.time() - startTime > self.timeout:
Line 1782:                 return False
Line 1783:             time.sleep(seconds)
Line 1784:             seconds *= 2
the step can become too huge this way. I'd prefer waiting on lifecycle event from libvirt
Line 1785: 
Line 1786:         return check()
Line 1787: 
Line 1788:     # Callbacks for Callback Chain


-- 
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da
Gerrit-PatchSet: 33
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list