Change in vdsm[master]: fcp: Deactivate vdsm logical volumes

nsoffer at redhat.com nsoffer at redhat.com
Mon Nov 11 15:30:34 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: fcp: Deactivate vdsm logical volumes
......................................................................


Patch Set 7:

> In master the implementation should be future maintainable not backward portable as suggested.

I think that backward portability is not less important than future maintainability.

> This means that if the entire logic can be closed in shell at pre-start in a simple manner, add this to pre-start and not vdsm-tool.

I can re-implement this in shell and put this in vdsmd_init_common.sh, and then create another patch using same or similar shell script for downstream, but this will be more work and will be harder to test and maintain.

I would like to have one file with the deactivation logic, that I can test separately from the context where it is used, and use the same file in both upstream and downstream.

How about installing this Python script where vdsm_init_common.sh is, and invoking it from pre-start task function in upstream, and from vdsmd.init in downstream?

-- 
To view, visit http://gerrit.ovirt.org/20720
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list