Change in vdsm[master]: lvm: Ensure active LVs are refreshed before use.

abaron at redhat.com abaron at redhat.com
Mon Nov 11 15:19:47 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: lvm: Ensure active LVs are refreshed before use.
......................................................................


Patch Set 5:

"2) "erroneous activation (e.g. https://bugzilla.redhat.com/1009812 use case)"
We cannot assert that the volume wasn't altered or is not still in use
(by the same or other reason) by other hosts. In such case refresh will not
help. The cause should be fixed and not mitigated. Are we aware of other
causes but the current BZ?"

If the volume is in use by some other host which is altering it then indeed there is nothing to do about it, but that is not the scenario nor is relevant to anything here.

In case the LV was erroneously activated in the past on *this* host then *not* refreshing it can and will lead to corruption while refresh will avoid that at the cost of the possible performance hit you are referring to.
corruption vs. perf hit... hmmm.  The answer is clear cut to me.
This is still +2

-- 
To view, visit http://gerrit.ovirt.org/19871
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list