Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet

agl at us.ibm.com agl at us.ibm.com
Fri May 31 13:14:52 UTC 2013


Adam Litke has posted comments on this change.

Change subject: gluster: new vdsm verb glusterHostUUIDGet
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 156: #
Line 157: # Since: 4.10.3
Line 158: ##
Line 159: {'type': 'HostUUID',
Line 160:  'data': {'uuid': 'UUID'}}
Do you really intend for this type to be a dictionary with a single key/value?

{'uuid': '5c1843a2-8dad-4b28-ae74-764b37c97da9'}

Other vdsm verbs simply use the 'str' type.
Line 161: 
Line 162: ##
Line 163: # @GlusterHost.uuid:
Line 164: #


--
To view, visit http://gerrit.ovirt.org/13785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf48b4c9530c48b2c46234d98c8cb4244adf22fd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list