Change in vdsm[master]: gluster: verbs for managing services

agl at us.ibm.com agl at us.ibm.com
Fri May 31 13:04:40 UTC 2013


Adam Litke has posted comments on this change.

Change subject: gluster: verbs for managing services
......................................................................


Patch Set 18: I would prefer that you didn't submit this

(1 inline comment)

One small change to make it correct.  You can test your schema file for validity with the following command:

./vdsm_api/process-schema.py vdsm/gluster/vdsmapi-gluster-schema.json out.html

....................................................
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 243: # status information for list of services
Line 244: #
Line 245: # Since: 4.10.3
Line 246: ##
Line 247: {'command': {'class': 'GlusterService', 'name': 'get'},
name needs to be 'manage'
Line 248:  'data': {'serviceName': 'str', 'action': 'GlusterServiceAction', 'failOnError': 'bool'},


--
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list