Change in vdsm[master]: vdsm-tool: service operations do not trigger abrt warning on...

danken at redhat.com danken at redhat.com
Wed May 29 03:46:09 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-tool: service operations do not trigger abrt warning on RHEL6
......................................................................


Patch Set 1: (1 inline comment)

....................................................
Commit Message
Line 8: 
Line 9: When an service management operation fails, the service module raises a
Line 10: RuntimeError, this triggers abrt warning of un-caught Python exceptions.
Line 11: This patch prints the error message to standard error and returns 1
Line 12: instead of raising exception.
Oh I see. runAlts confuses non-running service with a non existing one. Can this issue be solved? The next alt should be tried only if the first one does not exist.
Line 13: 
Line 14: Change-Id: Iddac6c6d1b6f47fe653ca4a86cc3a89f5ed4efb6


--
To view, visit http://gerrit.ovirt.org/15098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddac6c6d1b6f47fe653ca4a86cc3a89f5ed4efb6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list