Change in vdsm[master]: vdsm-tool: service operations do not trigger abrt warning on...

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Wed May 29 02:23:24 UTC 2013


Zhou Zheng Sheng has posted comments on this change.

Change subject: vdsm-tool: service operations do not trigger abrt warning on RHEL6
......................................................................


Patch Set 1: (1 inline comment)

Thanks Aravinda and Dan.

Management operations such as "service-status" and "service-is-managed" are to probe a service's status, they should return error code to the caller, and the caller decides what to do with the situation. Other operations like "service-start" and "service-stop" should raise exception if it fails.

....................................................
Commit Message
Line 8: 
Line 9: When an service management operation fails, the service module raises a
Line 10: RuntimeError, this triggers abrt warning of un-caught Python exceptions.
Line 11: This patch prints the error message to standard error and returns 1
Line 12: instead of raising exception.
When it wants to check a service status to see if it should start the service like follow,

  if vdsm-tool service-status XXX; then
    vdsm-tool service-start XXX
  fi

the service-status will cause an un-caught Python exception if the service is down.

Your consideration is reasonable. So I will submit a new patch set. For service-status, if the service is down, it just return 1, no un-caught exception. For other management operations such as service-start and service-stop, they raise exception if the operation fails.
Line 13: 
Line 14: Change-Id: Iddac6c6d1b6f47fe653ca4a86cc3a89f5ed4efb6


--
To view, visit http://gerrit.ovirt.org/15098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddac6c6d1b6f47fe653ca4a86cc3a89f5ed4efb6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list