Change in vdsm[master]: Removing mocking of _start function and add extraCmd variabl...

ybronhei at redhat.com ybronhei at redhat.com
Mon May 13 10:47:23 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Removing mocking of _start function and add extraCmd variable to proxy
......................................................................


Patch Set 3:

It doesn't work. As I wrote, you need to specify the path with the sudo command, otherwise you get root evn and you need to pass it to the execCmd, so it'll be almost the same as adding it to the command itself. Lets keep this patch if you accept it. It works and flexible for more use cases.

--
To view, visit http://gerrit.ovirt.org/14585
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I790fb1366bcfd369bd6be1618c284f2a945c19ca
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list