Change in vdsm[master]: Removing mocking of _start function and add extraCmd variabl...

danken at redhat.com danken at redhat.com
Sun May 12 11:26:49 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Removing mocking of _start function and add extraCmd variable to proxy
......................................................................


Patch Set 3:

Well, you said that you disliked your current solution, so I'm raising other ideas. The nicety of changing os.environ is that you avoid adding test-specific code to vdsm proper.

I can live with your current suggestion, but thought that setting supervdsm's PYTHONPATH is cleaner.

--
To view, visit http://gerrit.ovirt.org/14585
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I790fb1366bcfd369bd6be1618c284f2a945c19ca
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list