Change in vdsm[master]: vdsm: Catch the destkopLock AttributeError on Migration

vfeenstr at redhat.com vfeenstr at redhat.com
Mon May 6 13:02:49 UTC 2013


Vinzenz Feenstra has posted comments on this change.

Change subject: vdsm: Catch the destkopLock AttributeError on Migration
......................................................................


Patch Set 1: (1 inline comment)

> I feel sadder and sadder for covering after the spicec bug :-(
This has little to do with the spice connection issue, this issue must have been present even before that patch, which was introducing the timer.

I am not sure how the guestAgent object being None at the time when onDisconnect is called can possibly be related to that.

For me it looks like like an issue how we're handling the creation of Objects based on events coming from libvirt.
The same accounts for the _dom initialization and the exceptions on the hooks when trying to retrieve the dom xml...
I really start wondering if we're doing something fundamentally wrong in that area...

....................................................
File vdsm/vm.py
Line 826:         if not self.conf.get('clientIp', ''):
Line 827:             try:
Line 828:                 self.guestAgent.desktopLock()
Line 829:             except AttributeError:
Line 830:                 self.log.debug("Guest Agent not yet intialized")
Having it in onDisconnect was my first thought, however on the other side, it's more likely to succeed once the timer gets fired.
Line 831: 
Line 832:     def onDisconnect(self, detail=None):
Line 833:         self.conf['clientIp'] = ''
Line 834:         # This is a hack to mitigate the issue of spice-gtk not respecting the


--
To view, visit http://gerrit.ovirt.org/14395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6f6b2f2a3f049871902ee7777ae95ea9a52802
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list