Change in vdsm[master]: vdsm: Catch the destkopLock AttributeError on Migration

danken at redhat.com danken at redhat.com
Mon May 6 12:42:03 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Catch the destkopLock AttributeError on Migration
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

-1 for attention.

I feel sadder and sadder for covering after the spicec bug :-(

....................................................
File vdsm/vm.py
Line 826:         if not self.conf.get('clientIp', ''):
Line 827:             try:
Line 828:                 self.guestAgent.desktopLock()
Line 829:             except AttributeError:
Line 830:                 self.log.debug("Guest Agent not yet intialized")
could there be another way around it? can we avoid arming the _timedDesktopLock timer if guestAgent is still None?
Line 831: 
Line 832:     def onDisconnect(self, detail=None):
Line 833:         self.conf['clientIp'] = ''
Line 834:         # This is a hack to mitigate the issue of spice-gtk not respecting the


--
To view, visit http://gerrit.ovirt.org/14395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6f6b2f2a3f049871902ee7777ae95ea9a52802
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list