Change in vdsm[master]: vdsm: propagate MountError when mount fails
ewarszaw at redhat.com
ewarszaw at redhat.com
Tue Mar 19 13:57:33 UTC 2013
Eduardo has posted comments on this change.
Change subject: vdsm: propagate MountError when mount fails
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/storageServer.py
Line 213: exc_info=True)
Line 214: try:
Line 215: os.rmdir(self._getLocalPath())
Line 216: except OSError:
Line 217: pass
You should log here. Failing to remove the mount point points to a severe programming issue and may be the cause that failed the mount.
Please remove the comment.
Line 218: #We raise the MountError here since this is the real issue and not
Line 219: #the minor rmdir success.
Line 220: raise e
Line 221:
--
To view, visit http://gerrit.ovirt.org/10966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f36b3ea18690d7cf53439e5a0342b1495f4f181
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list