Change in vdsm[master]: Marking del/zero volumes in blockSD class.

danken at redhat.com danken at redhat.com
Tue Mar 19 12:38:28 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Marking del/zero volumes in blockSD class.
......................................................................


Patch Set 3: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm/storage/blockSD.py
Line 998:         self.rmDCImgDir(imgUUID, volsImgs)
Line 999: 
Line 1000:     def zeroImage(self, sdUUID, imgUUID, volsImgs):
Line 1001:         toZero = self._getImgExclusiveVols(imgUUID, volsImgs)
Line 1002:         self.__markForDelVols(sdUUID, imgUUID, toZero, sd.ZEROED_IMAGE_PREFIX)
ok, if this indeed does not introduce a new regression for Engine, it can go in.
Line 1003:         zeroImgVolumes(sdUUID, imgUUID, toZero)
Line 1004:         self.rmDCImgDir(imgUUID, volsImgs)
Line 1005: 
Line 1006:     def getAllVolumes(self):


--
To view, visit http://gerrit.ovirt.org/12545
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I747bc2218e0b2cc256dd352ad890143c7d354bd8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Gadi Ickowicz <gickowic at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list