Change in vdsm[master]: vdsm: create /etc/modules-load.d/vdsm.conf

danken at redhat.com danken at redhat.com
Sun Mar 10 16:16:49 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: create /etc/modules-load.d/vdsm.conf
......................................................................


Patch Set 13: (1 inline comment)

....................................................
File vdsm.spec.in
Line 474: %if 0%{?with_systemd}
Line 475: # Install the systemd scripts
Line 476: install -Dm 0755 vdsm/vdsmd.init %{buildroot}/lib/systemd/systemd-vdsmd
Line 477: /bin/sed -i '/\/usr\/bin\/vdsm-tool load-needed-modules/d' \
Line 478:     %{buildroot}/lib/systemd/systemd-vdsmd
oh, I did not notice this change...

I find it quite evil. We should not change files during rpm creation - what would happen once we're debianized?

This line should be skipped if vdsmd.init is run from within systemd. I'm certain there's a way to tell that.
Line 479: install -Dm 0644 vdsm/vdsmd.service %{buildroot}%{_unitdir}/vdsmd.service
Line 480: install -Dm 0644 vdsm/vdsm-restore-net-config.service \
Line 481:     %{buildroot}%{_unitdir}/vdsm-restore-net-config.service
Line 482: install -Dm 0755 vdsm_reg/vdsm-reg.init \


--
To view, visit http://gerrit.ovirt.org/11718
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I026ff658482ccefbdcc384785cdec10cf934b7d9
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list