Change in vdsm[master]: getAllTasksList\Status with 'spm_tasks' option retrieves in...

abaron at redhat.com abaron at redhat.com
Sun Mar 10 12:20:00 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: getAllTasksList\Status with 'spm_tasks' option  retrieves info only if host SPM
......................................................................


Patch Set 8:

Adding 1 variable in 'options' and 1 variable externally but mandating passing them both is ridiculous.
Edu and Saggi's conceptual mistake is in thinking that the request is for spm tasks and not pool tasks as I've explained in the previous comment.
The fact that you must be spm to get the pool tasks is an implementation detail.
I'm fine with spUUID being a parameter within options if Saggi thinks this way we can deprecate it more easily later on, but having both options and an external parameter which are both mandatory and the value of the first is always the same (true) when the second is passed or not pass anything is just meaningless, ugly and doesn't make anything simpler (you still end up with a parameter, but now your API is even less legible).

--
To view, visit http://gerrit.ovirt.org/12517
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel P. Berrange <berrange at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list