Change in vdsm[master]: vdsm.spec: Adding with_systemd macro

ybronhei at redhat.com ybronhei at redhat.com
Tue Mar 5 07:38:27 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm.spec: Adding with_systemd macro
......................................................................


Patch Set 7: (2 inline comments)

....................................................
File vdsm.spec.in
Line 480: install -Dm 0755 vdsm_reg/vdsm-reg.init \
Line 481:                  %{buildroot}/lib/systemd/systemd-vdsm-reg
Line 482: install -Dm 0644 vdsm_reg/vdsm-reg.service \
Line 483:                  %{buildroot}%{_unitdir}/vdsm-reg.service
Line 484: %else
Isn't this part should be only on rhel?.. does fedora <15 also use sysV init scripts?..
Line 485: # Install the SysV init scripts
Line 486: install -Dm 0755 vdsm/vdsmd.init %{buildroot}%{_initrddir}/vdsmd
Line 487: install -Dm 0755 vdsm_reg/vdsm-reg.init %{buildroot}%{_initrddir}/vdsm-reg
Line 488: install -Dm 0755 vdsm/vdsm-restore-net-config.init \


Line 651: 
Line 652: %files
Line 653: %defattr(-, root, root, -)
Line 654: %doc COPYING README vdsm/vdsm.conf.sample
Line 655: %if 0%{?with_systemd}
You change each if rhel to if with_systemd, means rhel>7 uses the same as fedora. fedora <15 uses same as rhel<7. Is that the case?
Line 656: /lib/systemd/systemd-vdsmd
Line 657: %{_unitdir}/vdsmd.service
Line 658: %{_unitdir}/vdsm-restore-net-config.service
Line 659: %else


--
To view, visit http://gerrit.ovirt.org/12086
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcd8567868e16453ed6633f143a6b1fff8e9c454
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list