Change in vdsm[master]: Logging: config logging in new process of remoteFileHandler

danken at redhat.com danken at redhat.com
Tue Mar 5 07:31:49 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Logging: config logging in new process of remoteFileHandler
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/remoteFileHandler.py
Line 33: 
Line 34: import misc
Line 35: import fileUtils
Line 36: import zombieReaper
Line 37: from vdsm import constants
there's a fat comment below, saying why we should not import anything from the vdsm package at this stage. Why is it fine now? Has the comment become stale?
Line 38: 
Line 39: # Crabs are known for their remote process calls
Line 40: LENGTH_STRUCT_FMT = "Q"
Line 41: LENGTH_STRUCT_LENGTH = calcsize(LENGTH_STRUCT_FMT)


--
To view, visit http://gerrit.ovirt.org/9182
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b3b9e2837d632c7532fcd8f7306ed50b0865b5c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list