Change in vdsm[master]: introducing virtio-scsi support

danken at redhat.com danken at redhat.com
Mon Jun 10 14:48:50 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: introducing virtio-scsi support
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm/vm.py
Line 1488:             driverAttrs['cache'] = self.cache
Line 1489: 
Line 1490:             self._setErrorPolicy(driverAttrs)
Line 1491:             diskelem.appendChildWithArgs('driver', **driverAttrs)
Line 1492:         elif self.device == 'lun':
This patchset is probably my fault, as I find it clearer. 'lun' is a new target added in this patch (I would have wished that virtio-scsi was added in a separate previous patch). This new target has similarities, but also differences, to the 'disk' target.

What is the meaning of error_policy for 'lun'? Does qemu trap scsi errors and stop qemu?

Indeed, silence while ignoring an arg is bad. Exception is better. But why is qcow2 is legitimate? libvirt's docs are very dramatic about the source being very raw:

 device='lun' will only be recognized for actual raw devices, never for individual partitions or LVM partitions (in those cases, the kernel will reject the generic SCSI commands, making it identical to device='disk'

(sorry for the possibly-stupid questions, I apparently do not understand the feature very well).
Line 1493:             driverAttrs = {'name': 'qemu'}
Line 1494:             driverAttrs['io'] = 'native'
Line 1495:             driverAttrs['type'] = 'raw'
Line 1496:             driverAttrs['cache'] = self.cache


-- 
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list