Change in vdsm[master]: vm: check disk alignment using virt-alignment-scan

fsimonce at redhat.com fsimonce at redhat.com
Mon Jun 10 14:28:34 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: vm: check disk alignment using virt-alignment-scan
......................................................................


Patch Set 10:

> For one's, do we really need/want to expose virtAlignScan in vdsm-python?

No idea, I saw qemuImg being in lib/vdsm and I followed the lead.

> Is the module rename needed now?

Will later be better than now?

> How is this related to the BLANK_UUID generalization (which iicr Eduardo wanted long ago)?

The BLANK_UUID is used when the VM is not running to run a cold (vs live) virtAlignScan.
The live virtAlignScan is probably relevant only for qcow, but nonetheless is something we should keep in mind.
If you want I can add a new BLANK_UUID definition or do something dirty as using a storage module in the virt area.

-- 
To view, visit http://gerrit.ovirt.org/12003
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list