Change in vdsm[master]: Extend vdsm-tool: moving configure libvirt to external shell...

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Thu Jun 6 09:33:14 UTC 2013


Zhou Zheng Sheng has posted comments on this change.

Change subject: Extend vdsm-tool: moving configure libvirt to external shell script
......................................................................


Patch Set 4: (2 inline comments)

....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 128:     if isOvirt
Line 129:     then
Line 130:         if [ ! -f /etc/pki/vdsm/certs/vdsmcert.pem ]
Line 131:         then
Line 132:             echo "$prog: Missing certificates, $prog not registered" 1>&2
prog variable definition is missing.
Line 133:             return 6
Line 134:         fi
Line 135:         /usr/bin/vdsm-tool validate-ovirt-certs
Line 136:     fi


....................................................
File vdsm/vdsmd.init.in
Line 31: RESPAWNPIDFILE=@VDSMRUNDIR@/respawn.pid
Line 32: CORE_DUMP_PATH=/var/log/core/core.%p.%t.dump
Line 33: DOM_METADATA_BACKUP_DIR=/var/log/vdsm/backup
Line 34: CORE_PATTERN=/proc/sys/kernel/core_pattern
Line 35: QEMU_DUMP_PATH="/var/log/core"
This variable should be moved to libvirt_configure.sh.in. No code in this file refer to it.
Line 36: NEEDED_SERVICES="iscsid multipathd ntpd wdmd sanlock network libvirtd
Line 37:                  supervdsmd"
Line 38: CONFLICTING_SERVICES="libvirt-guests"
Line 39: 


--
To view, visit http://gerrit.ovirt.org/15216
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id58b129afbf141a47a85b421961bf5b1776b41e4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list