Change in vdsm[master]: [WIP] hooks: Add Quantum vNIC hook

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Thu Jun 6 09:30:55 UTC 2013


Mark Wu has posted comments on this change.

Change subject: [WIP] hooks: Add Quantum vNIC hook
......................................................................


Patch Set 2: No score

(1 inline comment)

....................................................
File vdsm_hooks/quantumvnic/before_vm_start.py
Line 41:             target.setAttribute('dev', tapName)
Line 42:             iface.appendChild(target)
Line 43: 
Line 44:             source = iface.getElementsByTagName('source')[0]
Line 45:             source.setAttribute('bridge', DUMMY_BRIDGE)
if interface definition above doesn't work, you could try 
<script path='no'/>.  It could tell qemu disable running script. I know it's tricky and I don't remember if I have tested that before.
Line 46: 
Line 47: 
Line 48: def main():
Line 49:     domxml = hooking.read_domxml()


--
To view, visit http://gerrit.ovirt.org/11108
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I744b83d9c6027bd817e5d4171a77a005611b9818
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list