Change in vdsm[master]: Multiple Gateways[6/2]: Swapped libvirt network & netEnt cre...

amuller at redhat.com amuller at redhat.com
Thu Jul 11 12:18:40 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: Multiple Gateways[6/2]: Swapped libvirt network & netEnt creation
......................................................................


Patch Set 3: (1 inline comment)

Inline comment.

Thank you very much Mark for your thorough review!

....................................................
File vdsm/sourceRouteThread.py
Line 34:                 sourceRoute.configure(ip, mask, gateway)
Line 35:             else:
Line 36:                 sourceRoute.remove()
Line 37: 
Line 38:             sourceRoute.removeVDSMInterfaceTracking()
I think it'll work. I'll code it up and verify it up on my host. It will allow us to remove the pre-existing _isLibvirtInterface checks...
Line 39: 
Line 40:         os.remove(sourceRouteFilePath)
Line 41: 
Line 42:     def process_IN_CLOSE_WRITE(self, event):


-- 
To view, visit http://gerrit.ovirt.org/16692
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5af431909427dc7488875f0cb14fe4361657a83
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list