Change in vdsm[master]: Multiple Gateways[6/2]: Swapped libvirt network & netEnt cre...
wudxw at linux.vnet.ibm.com
wudxw at linux.vnet.ibm.com
Thu Jul 11 12:11:25 UTC 2013
Mark Wu has posted comments on this change.
Change subject: Multiple Gateways[6/2]: Swapped libvirt network & netEnt creation
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/sourceRoute.py
Line 119: logging.debug(">>> file exists")
Line 120: return True
Line 121: else:
Line 122: logging.debug("<<< file doesn't exist")
Line 123: return self._isLibvirtInterface()
if we don't remove the file after addNetwork, you still can use that file to tell if it's a vdsm interface
Line 124:
Line 125: def removeVDSMInterfaceTracking(self):
Line 126: try:
Line 127: os.remove(TRACKED_INTERFACES_FOLDER + '/' + self.device)
--
To view, visit http://gerrit.ovirt.org/16692
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5af431909427dc7488875f0cb14fe4361657a83
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list