Change in vdsm[master]: Remove redundant exception assignations.

shuming at linux.vnet.ibm.com shuming at linux.vnet.ibm.com
Mon Jan 21 01:26:43 UTC 2013


Shu Ming has posted comments on this change.

Change subject: Remove redundant exception assignations.
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/blockSD.py
Line 536:             misc.ddCopy("/dev/zero", path, RESERVED_METADATA_SIZE)
Line 537:             path = lvm.lvPath(vgName, sd.INBOX)
Line 538:             misc.ddCopy("/dev/zero", path, RESERVED_MAILBOX_SIZE)
Line 539:             path = lvm.lvPath(vgName, sd.OUTBOX)
Line 540:             misc.ddCopy("/dev/zero", path, RESERVED_MAILBOX_SIZE)
Why removing the whole exception case instead of removing "e" only? I think your intention is as the following:
except se.ActionStopped:
     raise
Line 541:         except se.StorageException:
Line 542:             raise se.VolumesZeroingError(path)
Line 543: 
Line 544:         if version in VERS_METADATA_LV:


--
To view, visit http://gerrit.ovirt.org/11034
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5521612493ee9d5a57816fbcd8a54b174d29aefb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list