Change in vdsm[master]: Remove redundant exception assignations.

danken at redhat.com danken at redhat.com
Sun Jan 20 20:06:27 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Remove redundant exception assignations.
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(2 inline comments)

....................................................
File vdsm/storage/blockSD.py
Line 536:             misc.ddCopy("/dev/zero", path, RESERVED_METADATA_SIZE)
Line 537:             path = lvm.lvPath(vgName, sd.INBOX)
Line 538:             misc.ddCopy("/dev/zero", path, RESERVED_MAILBOX_SIZE)
Line 539:             path = lvm.lvPath(vgName, sd.OUTBOX)
Line 540:             misc.ddCopy("/dev/zero", path, RESERVED_MAILBOX_SIZE)
this is true, but not trivial (I was surprised that ActionStopped is not a StorageException). I'd rather get the original author's opinion (Igor) about this.

If you just drop the "e", we can take the patch.
Line 541:         except se.StorageException:
Line 542:             raise se.VolumesZeroingError(path)
Line 543: 
Line 544:         if version in VERS_METADATA_LV:


....................................................
File vdsm/storage/image.py
Line 938:                         size=srcVol.getVolumeSize(bs=1),
Line 939:                         dstvolType=dstVol.getType())
Line 940:                     if rc:
Line 941:                         raise se.StorageException("rc: %s, err: %s" %
Line 942:                                                   (rc, err))
here too, closer scrutiny required.
Line 943:                 except se.StorageException as e:
Line 944:                     raise se.CopyImageError(str(e))
Line 945: 
Line 946:                 # Mark volume as SHARED


--
To view, visit http://gerrit.ovirt.org/11034
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5521612493ee9d5a57816fbcd8a54b174d29aefb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list