Change in vdsm[master]: Support for GLUSTERFS_DOMAIN

fsimonce at redhat.com fsimonce at redhat.com
Sun Jan 13 16:12:24 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: Support for GLUSTERFS_DOMAIN
......................................................................


Patch Set 12: (6 inline comments)

Few minor comments. Marking as -1 for visibility. WRT the architecture I'm not sure if this is the way we want to go. For the rest the patch looks fine.

....................................................
File vdsm/storage/glusterSD.py
Line 18:         return glusterVolume.GlusterVolume
Line 19: 
Line 20:     @staticmethod
Line 21:     def findDomainPath(sdUUID):
Line 22:         for tmpSdUUID, domainPath in fileSD.scanDomains(sd.GLUSTERSD_DIR +
os.path.join?
Line 23:                                                         "/*"):
Line 24:             if tmpSdUUID == sdUUID and mount.isMounted(os.path.join(domainPath,
Line 25:                                                        "..")):
Line 26:                 return domainPath


....................................................
File vdsm/storage/glusterVolume.py
Line 1: from volume import VmVolumeInfo
Line 2: import fileVolume
Line 3: from sdc import sdCache
Line 4: import string
maybe we can get rid of this.
Line 5: import supervdsm as svdsm
Line 6: 
Line 7: 
Line 8: class GlusterVolume(fileVolume.FileVolume):


Line 15:         """
Line 16:         Send info to represent Gluster volume as a network block device
Line 17:         """
Line 18:         rpath = sdCache.produce(self.sdUUID).getRemotePath()
Line 19:         rpath_list = string.rsplit(rpath, ":")
rpath.rsplit(":")
Line 20:         volfileServer = rpath_list[0]
Line 21:         volname = rpath_list[1]
Line 22: 
Line 23:         # Volume transport to Libvirt transport mapping


Line 20:         volfileServer = rpath_list[0]
Line 21:         volname = rpath_list[1]
Line 22: 
Line 23:         # Volume transport to Libvirt transport mapping
Line 24:         VOLUME_TRANS_MAP = {'TCP': 'tcp', 'RDMA': 'rdma'}
this might belong to the entire module or to the GlusterVolume class.
Line 25: 
Line 26:         # Extract the volume's transport using gluster cli
Line 27:         svdsmProxy = svdsm.getProxy()
Line 28:         volInfo = svdsmProxy.glusterVolumeInfo(volname)


Line 31:         # Use default port
Line 32:         volPort = "0"
Line 33: 
Line 34:         imgFilePath = self.getVolumePath()
Line 35:         imgFilePath_list = string.rsplit(imgFilePath, "/")
imgFilePath.rsplit...
Line 36:         imgFileRelPath = string.join(imgFilePath_list[4:], "/")
Line 37: 
Line 38:         glusterPath = volname + '/' + imgFileRelPath
Line 39: 


....................................................
File vdsm/storage/volume.py
Line 868:         volume to the VM in a different way than the standard 'path' way.
Line 869:         """
Line 870:         # By default, send path
Line 871:         return {'volType': VmVolumeInfo.TYPE_PATH,
Line 872:                 'path': self.getVolumePath()}
'path' might be redundant since in hsm.py already returns it (line 3054). We might want to decide if it makes sense to keep it here and remove it from there.
Line 873: 
Line 874:     def getMetaParam(self, key):
Line 875:         """
Line 876:         Get a value of a specific key


--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list