Change in vdsm[master]: tests/functional: Add GlusterSD functional test

fsimonce at redhat.com fsimonce at redhat.com
Sun Jan 13 15:46:17 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: tests/functional: Add GlusterSD functional test
......................................................................


Patch Set 4: (2 inline comments)

....................................................
File tests/functional/xmlrpcTests.py
Line 35: from storage.misc import execCmd
Line 36: from storage.misc import RollbackContext
Line 37: from vdsm.utils import CommandPath
Line 38: from vdsm import vdscli
Line 39: import string
Do you really need this?
Line 40: 
Line 41: if not config.getboolean('vars', 'xmlrpc_enable'):
Line 42:     raise SkipTest("XML-RPC Bindings are disabled")
Line 43: 


Line 410:             vfstype = conDict['vfstype']
Line 411:             options = conDict['options']
Line 412: 
Line 413:             # Check if gluster volume is created & started
Line 414:             glusterVolName = string.split(spec, ':')[1]
is there any problem with spec.split(":")[1]?
Line 415:             if not glusterVolName in self.glusterVolInfo['volumes']:
Line 416:                 raise SkipTest("Test volume %s not found. Pls create it "
Line 417:                                "and start it" % glusterVolName)
Line 418: 


--
To view, visit http://gerrit.ovirt.org/10196
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe27b138d78e0922a6455e0984813823a98aeb53
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list