Change in vdsm[master]: watchdog hook

asegurap at redhat.com asegurap at redhat.com
Wed Jan 9 12:00:43 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: watchdog hook
......................................................................


Patch Set 5: (2 inline comments)

....................................................
File vdsm_hooks/watchdog/before_vm_start.py
Line 36: 
Line 37:         hooking.write_domxml(domxml)
Line 38: 
Line 39:     except:
Line 40:         sys.stderr.write('watchdog: [unexpected error]: %s\n' % traceback.format_exc())
This should be split in two lines not to go over 80 chars.
        sys.stderr.write('watchdog: [unexpected error]: %s\n' %
                         traceback.format_exc())


Line 37:         hooking.write_domxml(domxml)
Line 38: 
Line 39:     except:
Line 40:         sys.stderr.write('watchdog: [unexpected error]: %s\n' % traceback.format_exc())
Line 41: 
The blank line at the end of line should be removed.


--
To view, visit http://gerrit.ovirt.org/10619
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1d21ff8e14013869d78532632e8485f0414793
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list